Skip to content

Refactor/all#32

Merged
Jamkris merged 24 commits intomainfrom
refactor/all
Apr 8, 2026
Merged

Refactor/all#32
Jamkris merged 24 commits intomainfrom
refactor/all

Conversation

@Jamkris
Copy link
Copy Markdown
Owner

@Jamkris Jamkris commented Apr 8, 2026

Summary of Changes

This pull request implements a comprehensive refactor of the Gemini CLI extension, focusing on command naming consistency, documentation structure, and execution silence. By adopting the /ecc- prefix for custom commands and organizing documentation into a localized directory structure, the project improves maintainability and user accessibility. Additionally, the removal of verbose logging from hook scripts addresses user feedback regarding terminal noise, ensuring a more seamless interaction model.

Highlights

  • Command Refactoring: Renamed core commands to use the /ecc- prefix (e.g., /ecc-plan, /ecc-docs) to align with the new naming convention.
  • Documentation Restructuring: Reorganized documentation into a structured docs/ directory with language-specific subdirectories (en, ko-KR, zh-CN) and added new guides for MCP configurations, skills, and contributing.
  • Silent Execution Policy: Refactored hook scripts to eliminate console output, ensuring a cleaner user experience by removing unnecessary logs during session lifecycle events.
  • Project Cleanup: Consolidated utility scripts into a dedicated scripts/ directory and removed redundant file-based command definitions.
Ignored Files
  • Ignored by pattern: .gemini/** (2)
    • .gemini/config.yaml
    • .gemini/styleguide.md
Activity
  • Initial PR submission by Jamkris.
  • Automated code review identified inconsistencies in command naming and redundant function calls.
  • Author addressed feedback regarding silent execution policy, confirming that silent tracking is intentional to reduce terminal noise.
  • Author clarified that specific version references in documentation (e.g., iOS 26) are accurate and intentional.
  • Documentation and command structure updated to reflect the new naming conventions and directory organization.

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request focuses on documentation improvements and a shift towards silent execution for hook scripts. Documentation has been updated across English, Korean, and Simplified Chinese versions, including corrected paths for installation scripts and new guides for MCP configurations. Several hook scripts were modified to remove verbose logging, and the test suite was updated to verify this silent behavior. Feedback was provided regarding the inconsistent use of console.error for hints in suggest-compact.js, which contradicts the new silent execution policy.

@Jamkris
Copy link
Copy Markdown
Owner Author

Jamkris commented Apr 8, 2026

/gemini review

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request reorganizes the project structure by moving documentation to a dedicated docs/ directory, introducing new commands like /ecc-plan and /ecc-docs, and silencing several background hooks to reduce terminal noise. Feedback focuses on correcting command names in the new TOML files to match their filenames, removing redundant function calls in session-start.js whose return values are now ignored, and addressing a typo in the skills documentation. Additionally, there is a concern regarding the suggest-compact.js hook, which now tracks tool calls silently without ever notifying the user, potentially rendering the feature ineffective.

@Jamkris
Copy link
Copy Markdown
Owner Author

Jamkris commented Apr 8, 2026

/gemini summary

@gemini-code-assist
Copy link
Copy Markdown

Summary of Changes

This pull request implements a comprehensive refactor of the Gemini CLI extension, focusing on command naming consistency, documentation structure, and execution silence. By adopting the /ecc- prefix for custom commands and organizing documentation into a localized directory structure, the project improves maintainability and user accessibility. Additionally, the removal of verbose logging from hook scripts addresses user feedback regarding terminal noise, ensuring a more seamless interaction model.

Highlights

  • Command Refactoring: Renamed core commands to use the /ecc- prefix (e.g., /ecc-plan, /ecc-docs) to align with the new naming convention.
  • Documentation Restructuring: Reorganized documentation into a structured docs/ directory with language-specific subdirectories (en, ko-KR, zh-CN) and added new guides for MCP configurations, skills, and contributing.
  • Silent Execution Policy: Refactored hook scripts to eliminate console output, ensuring a cleaner user experience by removing unnecessary logs during session lifecycle events.
  • Project Cleanup: Consolidated utility scripts into a dedicated scripts/ directory and removed redundant file-based command definitions.
Ignored Files
  • Ignored by pattern: .gemini/** (2)
    • .gemini/config.yaml
    • .gemini/styleguide.md
Activity
  • Initial PR submission by Jamkris.
  • Automated code review identified inconsistencies in command naming and redundant function calls.
  • Author addressed feedback regarding silent execution policy, confirming that silent tracking is intentional to reduce terminal noise.
  • Author clarified that specific version references in documentation (e.g., iOS 26) are accurate and intentional.
  • Documentation and command structure updated to reflect the new naming conventions and directory organization.

@Jamkris Jamkris merged commit 1e37694 into main Apr 8, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant